Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1568)

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 2736243002: Remove SearchTabHelperDelegate::OnWebContentsInstantSupportDisabled (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_tab_helper.cc
diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc
index 1400bbf9d73deaba35d08e091267c5654d7b6ca7..42b2bba428d45b29373d310f190678153eaeec7e 100644
--- a/chrome/browser/ui/search/search_tab_helper.cc
+++ b/chrome/browser/ui/search/search_tab_helper.cc
@@ -319,19 +319,6 @@ void SearchTabHelper::NavigationEntryCommitted(
web_contents_->GetController().GetVisibleEntry();
DCHECK(entry);
- // Already determined the instant support state for this page, do not reset
- // the instant support state.
- if (load_details.is_in_page) {
- // When an "in-page" navigation happens, we will not receive a
- // DidFinishLoad() event. Therefore, we will not determine the Instant
- // support for the navigated page. So, copy over the Instant support from
- // the previous entry. If the page does not support Instant, update the
- // location bar from here to turn off search terms replacement.
- if (delegate_ && model_.instant_support() == INSTANT_SUPPORT_NO)
- delegate_->OnWebContentsInstantSupportDisabled(web_contents_);
- return;
- }
-
model_.SetInstantSupportState(INSTANT_SUPPORT_UNKNOWN);
if (InInstantProcess(profile(), web_contents_))
@@ -488,11 +475,6 @@ void SearchTabHelper::InstantSupportChanged(bool instant_support) {
INSTANT_SUPPORT_NO;
model_.SetInstantSupportState(new_state);
-
- if (web_contents_->GetController().GetLastCommittedEntry() && delegate_ &&
- !instant_support) {
- delegate_->OnWebContentsInstantSupportDisabled(web_contents_);
- }
}
void SearchTabHelper::UpdateMode(bool update_origin) {

Powered by Google App Engine
This is Rietveld 408576698