Remove SearchTabHelperDelegate::OnWebContentsInstantSupportDisabled

chrome/browser/ui/browser.cc

Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index d2063c2f561ca8edecea3ef93c812f62903d6b41..80af40ace8265a67c1b07d71ed37ff2e4d08cb6b 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1969,13 +1969,6 @@ bool Browser::CanSaveContents(content::WebContents* web_contents) const {
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, SearchTabHelperDelegate implementation:
 
-void Browser::OnWebContentsInstantSupportDisabled(
-    const content::WebContents* web_contents) {
-  DCHECK(web_contents);
-  if (tab_strip_model_->GetActiveWebContents() == web_contents)
-    UpdateToolbar(false);
-}
-
 OmniboxView* Browser::GetOmniboxView() {

[Marc Treib, 2017/03/08 13:34:58]

This is now the only method left in SearchTabHelperDelegate. I think we can
remove the delegate, and instead just pass the OmniboxView* to the
SearchTabHelper directly, e.g. in Browser::TabInsertedAt. (That assumes that the
OmniboxView* won't change during the lifetime of the tab, which I think is
safe.)

If you agree, I'll do that in a follow-up (or in this CL, whichever you prefer).

[Peter Kasting, 2017/03/09 06:12:24]

I'd worry about the case of dragging a tab from one window to another.  An
OmniboxView is tied to a browser window, so if you dragged a tab from one window
to a different one, you'd want to make sure you weren't still pointing at the
omnibox from the previous window.

If in that case things get updated correctly, then you're welcome to make the
change in a follow-up CL.

[Marc Treib, 2017/03/09 10:04:47]

Thanks, I didn't think about that case! I'll investigate and then possibly send
that follow-up.

   return window_->GetLocationBar()->GetOmniboxView();
 }