Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2736233002:
Replace some webrtc rtc_base dependencies with rtc_base_approved (Closed)
|
Created:
3 years, 9 months ago by nisse-chromium (ooo August 14) Modified:
3 years, 9 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org, chromoting-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReplace some webrtc rtc_base dependencies with rtc_base_approved
BUG=None
Review-Url: https://codereview.chromium.org/2736233002
Cr-Commit-Position: refs/heads/master@{#456022}
Committed: https://chromium.googlesource.com/chromium/src/+/51a7f57411aada6b19a573f66df84f58599249d8
Patch Set 1 #Patch Set 2 : Add let content/test:test_support depend on rtc_base_approved. #Patch Set 3 : Put back content/test:content_unittests dependency on rtc_base #
Messages
Total messages: 36 (25 generated)
The CQ bit was checked by nisse@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
nisse@chromium.org changed reviewers: + kjellander@chromium.org, sergeyu@chromium.org
While tweaking webrtc deps, let's eliminate a few rtc_base dependencies too. kjellander, could you start a cq dryrun for me?
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Drop some unneeded dependencies on webrtc's rtc_base. Deleted, or replaced by rtc_base_approved. BUG=None ========== to ========== Replace some webrtc rtc_base dependencies with rtc_base_approved BUG=None ==========
The CQ bit was checked by nisse@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
It seems the trybots are now happy. PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kjellander@chromium.org changed reviewers: + tommi@chromium.org
lgtm +tommi for content/test
tommi@webrtc.org changed reviewers: + tommi@webrtc.org
lgtm. nice to fix this up.
and now from the right account... lgtm
The CQ bit was checked by tommi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
You still need sergeyu@, but I think it's fine to TBR him on a change like this.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by nisse@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489132784040310,
"parent_rev": "871bffc2d8203073da09b7ac16eec2e8a589725a", "commit_rev":
"51a7f57411aada6b19a573f66df84f58599249d8"}
Message was sent while issue was closed.
Description was changed from ========== Replace some webrtc rtc_base dependencies with rtc_base_approved BUG=None ========== to ========== Replace some webrtc rtc_base dependencies with rtc_base_approved BUG=None Review-Url: https://codereview.chromium.org/2736233002 Cr-Commit-Position: refs/heads/master@{#456022} Committed: https://chromium.googlesource.com/chromium/src/+/51a7f57411aada6b19a573f66df8... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/51a7f57411aada6b19a573f66df8... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
