Issue 2736223002: Transfer the notification icon through XPC as NSData for OSX 10.09

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2736223002: Transfer the notification icon through XPC as NSData for OSX 10.09 (Closed)

Created:
3 years, 9 months ago by Miguel Garcia

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

Transfer the notification icon through XPC as NSData for OSX 10.09 This is because NSImage only started conforming to NSecureCoding in 10.10 BUG=696759 Review-Url: https://codereview.chromium.org/2728173003 Cr-Commit-Position: refs/heads/master@{#454916} (cherry picked from commit 52f904d3bf07e423a6bb907ff6f344935532affa) Review-Url: https://codereview.chromium.org/2736223002 . Cr-Commit-Position: refs/branch-heads/3029@{#62} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/5d850e88b25328644823ce00fab4f66fdfeb8278

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
	M	chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm	View		3 chunks	+18 lines, -4 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Miguel Garcia

3 years, 9 months ago (2017-03-08 12:22:04 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5d850e88b25328644823ce00fab4f66fdfeb8278.