Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: pkg/front_end/lib/src/fasta/parser/parser.dart

Issue 2736093003: [fasta] Add and correct offsets on nodes (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/parser/parser.dart
diff --git a/pkg/front_end/lib/src/fasta/parser/parser.dart b/pkg/front_end/lib/src/fasta/parser/parser.dart
index ecbe4830c05cf231681d0b393da6e1064ca9ef96..d685aa4e13e00f7f966a4321840153d5e0e9a38d 100644
--- a/pkg/front_end/lib/src/fasta/parser/parser.dart
+++ b/pkg/front_end/lib/src/fasta/parser/parser.dart
@@ -2603,6 +2603,7 @@ class Parser {
}
Token parseArgumentOrIndexStar(Token token) {
+ Token beginToken = token;
while (true) {
if (optional('[', token)) {
Token openSquareBracket = token;
@@ -2615,7 +2616,7 @@ class Parser {
} else if (optional('(', token)) {
listener.handleNoTypeArguments(token);
token = parseArguments(token);
- listener.endSend(token);
+ listener.endSend(beginToken, token);
} else {
break;
}
@@ -2717,25 +2718,27 @@ class Parser {
}
Token parseThisExpression(Token token) {
+ Token beginToken = token;
listener.handleThisExpression(token);
token = token.next;
if (optional('(', token)) {
// Constructor forwarding.
listener.handleNoTypeArguments(token);
token = parseArguments(token);
- listener.endSend(token);
+ listener.endSend(beginToken, token);
}
return token;
}
Token parseSuperExpression(Token token) {
+ Token beginToken = token;
listener.handleSuperExpression(token);
token = token.next;
if (optional('(', token)) {
// Super constructor.
listener.handleNoTypeArguments(token);
token = parseArguments(token);
- listener.endSend(token);
+ listener.endSend(beginToken, token);
}
return token;
}
@@ -3024,6 +3027,7 @@ class Parser {
}
Token parseSend(Token token, IdentifierContext context) {
+ Token beginToken = token;
listener.beginSend(token);
token = parseIdentifier(token, context);
if (isValidMethodTypeArguments(token)) {
@@ -3032,7 +3036,7 @@ class Parser {
listener.handleNoTypeArguments(token);
}
token = parseArgumentsOpt(token);
- listener.endSend(token);
+ listener.endSend(beginToken, token);
return token;
}
@@ -3150,10 +3154,11 @@ class Parser {
}
Token parseOptionallyInitializedIdentifier(Token token) {
+ Token nameToken = token;
listener.beginInitializedIdentifier(token);
token = parseIdentifier(token, IdentifierContext.localVariableDeclaration);
token = parseVariableInitializerOpt(token);
- listener.endInitializedIdentifier();
+ listener.endInitializedIdentifier(nameToken);
return token;
}

Powered by Google App Engine
This is Rietveld 408576698