Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2736073002: Set AVDISCARD_ALL flag for disabled streams in FFmpegDemuxer (Closed)

Created:
3 years, 9 months ago by servolk
Modified:
3 years, 9 months ago
Reviewers:
hubbe, tguilbert, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set AVDISCARD_ALL flag for disabled streams in FFmpegDemuxer The AVDISCARD_ALL flag allows FFmpeg to not care about key frames for disabled streams, which results in less data being read from the data source as new tests demonstrate. BUG=157993 Review-Url: https://codereview.chromium.org/2736073002 Cr-Commit-Position: refs/heads/master@{#455370} Committed: https://chromium.googlesource.com/chromium/src/+/e67994a48c6c65cfef9f92ebda32baf0cf4d7018

Patch Set 1 #

Patch Set 2 : Use AVDISCARD_DEFAULT instead of _NONE #

Patch Set 3 : Set AV_DISCARDALL also for disabled subtitle streams and unsupported streams #

Patch Set 4 : Added a test case for text track #

Patch Set 5 : Added test case for the disabled video stream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -1 line) Patch
M media/filters/ffmpeg_demuxer.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 2 3 4 3 chunks +75 lines, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
servolk
3 years, 9 months ago (2017-03-08 01:05:36 UTC) #8
DaleCurtis
lgtm, thanks for putting this together so quickly!
3 years, 9 months ago (2017-03-08 01:34:20 UTC) #10
hubbe
lgtm
3 years, 9 months ago (2017-03-08 01:35:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736073002/80001
3 years, 9 months ago (2017-03-08 01:39:39 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 03:24:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e67994a48c6c65cfef9f92ebda32...

Powered by Google App Engine
This is Rietveld 408576698