SurfaceIds must be reusable as soon as their surfaces are marked destroyed

cc/surfaces/surface_manager.h

Index: cc/surfaces/surface_manager.h
diff --git a/cc/surfaces/surface_manager.h b/cc/surfaces/surface_manager.h
index e4b6f17c5f6efd6e22edeca7795c5dfe9db6748d..12e7d5a35f86051d085a07c8018639ea1a1a8cde 100644
--- a/cc/surfaces/surface_manager.h
+++ b/cc/surfaces/surface_manager.h
@@ -65,11 +65,14 @@ class CC_SURFACES_EXPORT SurfaceManager {
 
   void RequestSurfaceResolution(Surface* pending_surface);
 
-  void RegisterSurface(Surface* surface);
   void DeregisterSurface(const SurfaceId& surface_id);
 
+  std::unique_ptr<Surface> CreateSurface(

[Fady Samuel, 2017/03/09 21:32:16]

Here's a safer signature:

std::unique_ptr<Surface> CreateSurface(base::WeakPtr<SurfaceFactory>, const
LocalSurfaceId& local_surface_id);

Then use the frame_sink_id(), and local_surface_id to allocate the surface. That
way you cannot allocate a SurfaceId that doesn't belong to the factory you're
passing in?

WDYT?

[Saman Sami, 2017/03/09 21:45:17]

I like it.

+      SurfaceId surface_id,

[Fady Samuel, 2017/03/09 21:32:16]

looks like you missed making this const SurfaceId& 

[Saman Sami, 2017/03/09 21:45:17]

Done.

+      base::WeakPtr<SurfaceFactory> surface_factory);
+
   // Destroy the Surface once a set of sequence numbers has been satisfied.
-  void Destroy(std::unique_ptr<Surface> surface);
+  void DestroySurface(std::unique_ptr<Surface> surface);
 
   Surface* GetSurfaceForId(const SurfaceId& surface_id);