SurfaceIds must be reusable as soon as their surfaces are marked destroyed

cc/surfaces/surface_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_SURFACES_SURFACE_MANAGER_H_
 #define CC_SURFACES_SURFACE_MANAGER_H_
 
 #include <stdint.h>
 
 #include <list>
@@ skipping 47 matching lines @@
 #endif
 
   void SetDependencyTracker(
       std::unique_ptr<SurfaceDependencyTracker> dependency_tracker);
   SurfaceDependencyTracker* dependency_tracker() {
     return dependency_tracker_.get();
   }
 
   void RequestSurfaceResolution(Surface* pending_surface);
 
-  void RegisterSurface(Surface* surface);
   void DeregisterSurface(const SurfaceId& surface_id);
 
+  std::unique_ptr<Surface> CreateSurface(

[Fady Samuel, 2017/03/09 21:32:16]

Here's a safer signature:

std::unique_ptr<Surface> CreateSurface(base::WeakPtr<SurfaceFactory>, const
LocalSurfaceId& local_surface_id);

Then use the frame_sink_id(), and local_surface_id to allocate the surface. That
way you cannot allocate a SurfaceId that doesn't belong to the factory you're
passing in?

WDYT?

[Saman Sami, 2017/03/09 21:45:17]

I like it.

+      SurfaceId surface_id,

[Fady Samuel, 2017/03/09 21:32:16]

looks like you missed making this const SurfaceId& 

[Saman Sami, 2017/03/09 21:45:17]

Done.

+      base::WeakPtr<SurfaceFactory> surface_factory);
+
   // Destroy the Surface once a set of sequence numbers has been satisfied.
-  void Destroy(std::unique_ptr<Surface> surface);
+  void DestroySurface(std::unique_ptr<Surface> surface);
 
   Surface* GetSurfaceForId(const SurfaceId& surface_id);
 
   void AddObserver(SurfaceObserver* obs) { observer_list_.AddObserver(obs); }
 
   void RemoveObserver(SurfaceObserver* obs) {
     observer_list_.RemoveObserver(obs);
   }
 
   bool SurfaceModified(const SurfaceId& surface_id);
@@ skipping 225 matching lines @@
   std::unique_ptr<SurfaceDependencyTracker> dependency_tracker_;
 
   base::WeakPtrFactory<SurfaceManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(SurfaceManager);
 };
 
 }  // namespace cc
 
 #endif  // CC_SURFACES_SURFACE_MANAGER_H_