Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2736033003: [Merge M57] arc: Provide more logging for network failures. (Closed)

Created:
3 years, 9 months ago by khmel
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge M57] arc: Provide more logging for network failures. This add more loggin for network failures and handles network timeouts as dedicated UMA entry. NOTRY=true NOPRESUBMIT=true TBR=isherman@chromium.org,yusukes@chromium.org,dcheng@chromium.org BUG=697579 Test=Manually. Emulate network unavailble error. GMS Services error is shown. chrome:://histograms shows value 19 recorded. Update only ARC side and repeat the test to validate condition with mojo different versions. The same error is shown but UMA value 14 is recorded in UMA (legacy case) Review-Url: https://codereview.chromium.org/2723263003 Cr-Commit-Position: refs/heads/master@{#454501} (cherry picked from commit 337f3e54b359b2b83950d4e61d5c6b05108bc630) Review-Url: https://codereview.chromium.org/2736033003 Cr-Commit-Position: refs/branch-heads/2987@{#786} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/fdc90f4b2b62c8e7f8bef55f3293924b6430b0a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_optin_uma.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_optin_uma.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/arc/common/auth.mojom View 3 chunks +5 lines, -2 lines 0 comments Download
M components/arc/net/arc_net_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736033003/1
3 years, 9 months ago (2017-03-07 16:42:43 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 16:46:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fdc90f4b2b62c8e7f8bef55f3293...

Powered by Google App Engine
This is Rietveld 408576698