Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2736003003: Try to show the full ellipsis at all times (Closed)

Created:
3 years, 9 months ago by rhogan
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to show the full ellipsis at all times BUG=697448 Review-Url: https://codereview.chromium.org/2736003003 Cr-Commit-Position: refs/heads/master@{#455937} Committed: https://chromium.googlesource.com/chromium/src/+/246a46ddac2484d3860a4661010a683b0ab02289

Patch Set 1 #

Patch Set 2 : bug 697448 #

Patch Set 3 : bug 697448 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -65 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-block-with-border-and-padding-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-block-with-border-and-padding-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-strict-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-center-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-center-expected.txt View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-justify-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-left-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-right-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-right-expected.txt View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-input-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/line-clamp-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-ltr-flow-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-rtl-flow-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-platform-font-change-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-with-list-marker-in-ltr-flow-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/emphasis-ellipsis-complextext-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
rhogan
3 years, 9 months ago (2017-03-08 20:20:13 UTC) #6
eae
OK, LGTM
3 years, 9 months ago (2017-03-09 01:22:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736003003/40001
3 years, 9 months ago (2017-03-09 23:07:45 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 01:05:57 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/246a46ddac2484d3860a4661010a...

Powered by Google App Engine
This is Rietveld 408576698