[Android] Showing keywords for all search engines on Android

[Android] Showing keywords for all search engines on Android

Current version of Chrome only dislays the keyword for a custom search
engine. However, for a prepopulated search engine whose engine name
might be a different language (ex sogou.com) from English, it will be
confusing for users.

To solve this, all search engines' keywords will be displayed to help
users linking the engine names to the actual domain of the search engines.

BUG=664336
Review-Url: https://codereview.chromium.org/2735993004
Cr-Commit-Position: refs/heads/master@{#455836}
Committed: https://chromium.googlesource.com/chromium/src/+/8ef0824d3d4405656ced11fd2f6e3fbf66952502

[ltian, 2017-03-08 22:32:41]

ltian@chromium.org changed reviewers:
+ tedchoc@chromium.org

[ltian, 2017-03-08 22:32:42]

tedchoc@chromium.org: could you take a look of my change in this cl?

Thanks!

[Ted C, 2017-03-09 00:51:24]

lgtm

https://codereview.chromium.org/2735993004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
(right):

https://codereview.chromium.org/2735993004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:318:
if (templateUrl.getKeyword().length() == 0) {
Since we're here, I would change .length() == 0 to .isEmpty().  Or if you want
to be more cautious, use TextUtils.isEmpty(templateUrl.getKeyword())

[ltian, 2017-03-09 19:00:53]

The CQ bit was checked by ltian@chromium.org

[ltian, 2017-03-09 19:01:02]

The CQ bit was unchecked by ltian@chromium.org

[ltian, 2017-03-09 19:03:58]

https://codereview.chromium.org/2735993004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
(right):

https://codereview.chromium.org/2735993004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:318:
if (templateUrl.getKeyword().length() == 0) {
On 2017/03/09 00:51:23, Ted C wrote:
> Since we're here, I would change .length() == 0 to .isEmpty().  Or if you want
> to be more cautious, use TextUtils.isEmpty(templateUrl.getKeyword())

Done.

[ltian, 2017-03-09 19:04:05]

The CQ bit was checked by ltian@chromium.org

[ltian, 2017-03-09 19:04:05]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2735993004/#ps20001
(title: "Update based on Ted's comment.")

[commit-bot: I haz the power, 2017-03-09 19:04:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 19:48:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489086245000300,
"parent_rev": "b2053f54f251c0bec07134dc401826a8705bae7c", "commit_rev":
"8ef0824d3d4405656ced11fd2f6e3fbf66952502"}

[commit-bot: I haz the power, 2017-03-09 19:49:04]

Description was changed from

==========
[Android] Showing keywords for all search engines on Android

Current version of Chrome only dislays the keyword for a custom search
engine. However, for a prepopulated search engine whose engine name
might be a different language (ex sogou.com) from English, it will be
confusing for users.

To solve this, all search engines' keywords will be displayed to help
users linking the engine names to the actual domain of the search engines.

BUG=664336
==========

to

==========
[Android] Showing keywords for all search engines on Android

Current version of Chrome only dislays the keyword for a custom search
engine. However, for a prepopulated search engine whose engine name
might be a different language (ex sogou.com) from English, it will be
confusing for users.

To solve this, all search engines' keywords will be displayed to help
users linking the engine names to the actual domain of the search engines.

BUG=664336

Review-Url: https://codereview.chromium.org/2735993004
Cr-Commit-Position: refs/heads/master@{#455836}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ef0824d3d4405656ced11fd2f6e...
==========

[commit-bot: I haz the power, 2017-03-09 19:49:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8ef0824d3d4405656ced11fd2f6e...