Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2735973002: Enable MidiManagerDynamicInstantiation feature in variations test (Closed)

Created:
3 years, 9 months ago by Takashi Toyoshima
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable MidiManagerDynamicInstantiation feature in variations test BUG=694138, 672793 Review-Url: https://codereview.chromium.org/2735973002 Cr-Commit-Position: refs/heads/master@{#455363} Committed: https://chromium.googlesource.com/chromium/src/+/efb905341311f9d9dc5ad9a53f6cfe7c0859d18c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Takashi Toyoshima
PTAL (try failures on windows must not be a real issue)
3 years, 9 months ago (2017-03-07 09:06:29 UTC) #8
Ilya Sherman
LGTM
3 years, 9 months ago (2017-03-08 01:39:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735973002/1
3 years, 9 months ago (2017-03-08 02:04:41 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 03:11:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/efb905341311f9d9dc5ad9a53f6c...

Powered by Google App Engine
This is Rietveld 408576698