Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Issue 2735943005: Override CreateNewTarget in the HeadlessDevToolsManagerDelegate to be able to create new tabs in he… (Closed)

Created:
3 years, 9 months ago by Oleg Sushkov
Modified:
3 years, 9 months ago
Reviewers:
Sami
CC:
chromium-reviews, devtools-reviews_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Override CreateNewTarget in the HeadlessDevToolsManagerDelegate to be able to create new tabs in headless mode from the json/new endpoint BUG=699392 Review-Url: https://codereview.chromium.org/2735943005 Cr-Commit-Position: refs/heads/master@{#455669} Committed: https://chromium.googlesource.com/chromium/src/+/8e621e208f82c7136a6dc8f32e0db7c6df00685d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M headless/lib/browser/headless_devtools_manager_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_devtools_manager_delegate.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Oleg Sushkov
3 years, 9 months ago (2017-03-08 05:19:58 UTC) #2
Sami
lgtm, thanks!
3 years, 9 months ago (2017-03-08 10:45:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735943005/1
3 years, 9 months ago (2017-03-09 04:13:11 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 04:56:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e621e208f82c7136a6dc8f32e0d...

Powered by Google App Engine
This is Rietveld 408576698