Add Precache.Fetch.ResponseBytes.Daily.

Add Precache.Fetch.ResponseBytes.Daily.

This measures how much of the daily_quota_total is used, allowing us to
predict what the effects will be if we tweak that parameter.

BUG=698933
Review-Url: https://codereview.chromium.org/2735923002
Cr-Commit-Position: refs/heads/master@{#455323}
Committed: https://chromium.googlesource.com/chromium/src/+/fd9e5cd40b36a72ab0803325f3d3910c90c84ec5

[twifkak, 2017-03-07 01:58:44]

twifkak@chromium.org changed reviewers:
+ jamartin@chromium.org, rkaplow@chromium.org

[rkaplow, 2017-03-07 15:48:50]

lgtm

[jamartin, 2017-03-07 21:10:12]

lgtm

https://codereview.chromium.org/2735923002/diff/1/components/precache/core/pr...
File components/precache/core/precache_fetcher.cc (right):

https://codereview.chromium.org/2735923002/diff/1/components/precache/core/pr...
components/precache/core/precache_fetcher.cc:724: quota_.remaining(),
(opt) It would be nice to have a bit more documentation in the Quota proto. It
took me a while to figure out the meaning of the fields and how they were
supposed to be used.

https://codereview.chromium.org/2735923002/diff/1/components/precache/core/pr...
components/precache/core/precache_fetcher.cc:725: 1, kMaxResponseBytes, 100);
I assume you eyeballed the bucket values and they make sense for this case,
right?

https://codereview.chromium.org/2735923002/diff/1/components/precache/core/pr...
components/precache/core/precache_fetcher.cc:728: // end of today.
Keep the comment at the beginning of the if block.

[twifkak, 2017-03-07 21:45:09]

https://codereview.chromium.org/2735923002/diff/1/components/precache/core/pr...
File components/precache/core/precache_fetcher.cc (right):

https://codereview.chromium.org/2735923002/diff/1/components/precache/core/pr...
components/precache/core/precache_fetcher.cc:724: quota_.remaining(),
On 2017/03/07 21:10:12, jamartin wrote:
> (opt) It would be nice to have a bit more documentation in the Quota proto. It
> took me a while to figure out the meaning of the fields and how they were
> supposed to be used.

Done.

https://codereview.chromium.org/2735923002/diff/1/components/precache/core/pr...
components/precache/core/precache_fetcher.cc:725: 1, kMaxResponseBytes, 100);
On 2017/03/07 21:10:12, jamartin wrote:
> I assume you eyeballed the bucket values and they make sense for this case,
> right?

Yes. The max is 500MB, which is more than enough for the 40MB/day we allot. The
bucket config is the same as the other ResponseBytes histos, and provide enough
detail for those (which sit around the 10MB range).

https://codereview.chromium.org/2735923002/diff/1/components/precache/core/pr...
components/precache/core/precache_fetcher.cc:728: // end of today.
On 2017/03/07 21:10:12, jamartin wrote:
> Keep the comment at the beginning of the if block.

Done.

[twifkak, 2017-03-07 21:45:34]

The CQ bit was checked by twifkak@chromium.org

[twifkak, 2017-03-07 21:45:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamartin@chromium.org, rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2735923002/#ps20001
(title: "Comment fixes.")

[commit-bot: I haz the power, 2017-03-07 21:46:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:36:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 22:36:17]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[twifkak, 2017-03-07 22:58:03]

The CQ bit was checked by twifkak@chromium.org

[twifkak, 2017-03-07 22:58:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamartin@chromium.org, rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2735923002/#ps40001
(title: "Don't report zero usage on first-time flow.")

[commit-bot: I haz the power, 2017-03-07 22:58:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 01:26:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488927483288210,
"parent_rev": "5f0ff79896d3a6aa7a93de31cfa192c2312e5d7f", "commit_rev":
"fd9e5cd40b36a72ab0803325f3d3910c90c84ec5"}

[commit-bot: I haz the power, 2017-03-08 01:27:53]

Description was changed from

==========
Add Precache.Fetch.ResponseBytes.Daily.

This measures how much of the daily_quota_total is used, allowing us to
predict what the effects will be if we tweak that parameter.

BUG=698933
==========

to

==========
Add Precache.Fetch.ResponseBytes.Daily.

This measures how much of the daily_quota_total is used, allowing us to
predict what the effects will be if we tweak that parameter.

BUG=698933

Review-Url: https://codereview.chromium.org/2735923002
Cr-Commit-Position: refs/heads/master@{#455323}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd9e5cd40b36a72ab0803325f3d3...
==========

[commit-bot: I haz the power, 2017-03-08 01:27:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fd9e5cd40b36a72ab0803325f3d3...