Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 2735903006: Reland of Add test for crbug.com/667045 (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
wkorman, hbos_chromium
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add test for crbug.com/667045 (patchset #1 id:1 of https://codereview.chromium.org/2557433004/ ) Reason for revert: Re-add the test case to reproduce the bug. The test will be expected to fail. Original issue's description: > Revert of Add test for crbug.com/667045 (patchset #2 id:20001 of https://codereview.chromium.org/2551803004/ ) > > Reason for revert: > The added tests are failing on many bots, e.g: > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/20708 > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/524 > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/27408 > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/9599 > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.9/builds/40397 > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/17898 > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7/builds/48488 > > Original issue's description: > > Add test for crbug.com/667045 > > > > The bug has been fixed by painting all collapsed borders of a table > > as one display item. > > > > BUG=667045 > > > > Committed: https://crrev.com/1f029bf28962ff78d2394dfee4258a3f23fe91bd > > Cr-Commit-Position: refs/heads/master@{#436467} > > TBR=wkorman@chromium.org,wangxianzhu@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=667045 > > Committed: https://crrev.com/eca747d2319680846ef1d37c2751d67a7c3144da > Cr-Commit-Position: refs/heads/master@{#436565} TBR=wkorman@chromium.org,hbos@chromium.org BUG=667045 Review-Url: https://codereview.chromium.org/2735903006 Cr-Commit-Position: refs/heads/master@{#455529} Committed: https://chromium.googlesource.com/chromium/src/+/073e1744a8b06f5d757b7fa71133f687652f1e18

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Xianzhu
Created Reland of Add test for crbug.com/667045
3 years, 9 months ago (2017-03-08 16:57:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735903006/70001
3 years, 9 months ago (2017-03-08 17:00:30 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/397073)
3 years, 9 months ago (2017-03-08 18:30:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735903006/90001
3 years, 9 months ago (2017-03-08 18:50:15 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 20:28:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/073e1744a8b06f5d757b7fa71133...

Powered by Google App Engine
This is Rietveld 408576698