Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2735823005: Implement a non-recursive PrePaint treewalk (Closed)

Created:
3 years, 9 months ago by pdr.
Modified:
3 years, 9 months ago
Reviewers:
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement a non-recursive PrePaint treewalk BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : faster push_back #

Patch Set 3 : Faster, cleaner #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -20 lines) Patch
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 2 3 chunks +43 lines, -19 lines 1 comment Download

Messages

Total messages: 10 (9 generated)
pdr.
3 years, 9 months ago (2017-03-08 01:04:59 UTC) #10
https://codereview.chromium.org/2735823005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp (right):

https://codereview.chromium.org/2735823005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:88:
Vector<PrePaintTreeWalkContext> stack;
This has a bug: when the vector resizes, parent pointers in
PrePaintTreeWalkContext.paintInvalidatorContext are no longer valid. This should
use a linked list instead.

Powered by Google App Engine
This is Rietveld 408576698