Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2735823004: ChromeOS OOBE: OOBE should listen to notification of keyboard layout update. (Closed)

Created:
3 years, 9 months ago by Alexander Alekseev
Modified:
3 years, 9 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: OOBE should listen to notification of keyboard layout update. BUG=665613 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2735823004 Cr-Commit-Position: refs/heads/master@{#455423} Committed: https://chromium.googlesource.com/chromium/src/+/ae2ff2acd161f2be4c49d0278ca2d515ef8a1842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_network.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Alexander Alekseev
Please review.
3 years, 9 months ago (2017-03-07 04:32:49 UTC) #3
michaelpg
lgtm
3 years, 9 months ago (2017-03-07 18:40:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735823004/1
3 years, 9 months ago (2017-03-08 02:24:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/335855)
3 years, 9 months ago (2017-03-08 05:50:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735823004/1
3 years, 9 months ago (2017-03-08 09:30:43 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 10:25:14 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae2ff2acd161f2be4c49d0278ca2...

Powered by Google App Engine
This is Rietveld 408576698