Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by Kai Ninomiya Modified:
3 years, 9 months ago Reviewers:
Zhenyao Mo CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionExpand 2 Linux/NVIDIA workarounds to Android/NVIDIA
pack_parameters_workaround_with_pack_buffer fixes
conformance2/reading/read-pixels-pack-parameters.html
unpack_alignment_workaround_with_unpack_buffer fixes
conformance2/textures/misc/tex-unpack-params.html
BUG=698926
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2735823003
Cr-Commit-Position: refs/heads/master@{#455394}
Committed: https://chromium.googlesource.com/chromium/src/+/08e70dd3bd712e9d57a420c34e98b4eaef25599f
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove extra blank line #Patch Set 3 : fix id #
Created: 3 years, 9 months ago
Messages
Total messages: 24 (15 generated)
Description was changed from ========== Expand 2 Linux/NVIDIA workarounds to Android/NVIDIA pack_parameters_workaround_with_pack_buffer fixes conformance2/reading/read-pixels-pack-parameters.html unpack_alignment_workaround_with_unpack_buffer fixes conformance2/textures/misc/tex-unpack-params.html BUG=698926 ========== to ========== Expand 2 Linux/NVIDIA workarounds to Android/NVIDIA pack_parameters_workaround_with_pack_buffer fixes conformance2/reading/read-pixels-pack-parameters.html unpack_alignment_workaround_with_unpack_buffer fixes conformance2/textures/misc/tex-unpack-params.html BUG=698926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kainino@chromium.org changed reviewers: + zmo@chromium.org
zmo, ptal
lgtm https://codereview.chromium.org/2735823003/diff/1/gpu/config/gpu_driver_bug_l... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2735823003/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list_json.cc:2372: nit: this looks unintentional?
The CQ bit was checked by kainino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2735823003/#ps20001 (title: "remove extra blank line")
https://codereview.chromium.org/2735823003/diff/1/gpu/config/gpu_driver_bug_l... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2735823003/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list_json.cc:2372: On 2017/03/07 17:13:49, Zhenyao Mo wrote: > nit: this looks unintentional? oops, done
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by kainino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2735823003/#ps40001 (title: "fix id")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kainino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488956637849680,
"parent_rev": "ff471aaa050676692ee93b5d3c786f4cf87396d6", "commit_rev":
"08e70dd3bd712e9d57a420c34e98b4eaef25599f"}
Message was sent while issue was closed.
Description was changed from ========== Expand 2 Linux/NVIDIA workarounds to Android/NVIDIA pack_parameters_workaround_with_pack_buffer fixes conformance2/reading/read-pixels-pack-parameters.html unpack_alignment_workaround_with_unpack_buffer fixes conformance2/textures/misc/tex-unpack-params.html BUG=698926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Expand 2 Linux/NVIDIA workarounds to Android/NVIDIA pack_parameters_workaround_with_pack_buffer fixes conformance2/reading/read-pixels-pack-parameters.html unpack_alignment_workaround_with_unpack_buffer fixes conformance2/textures/misc/tex-unpack-params.html BUG=698926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2735823003 Cr-Commit-Position: refs/heads/master@{#455394} Committed: https://chromium.googlesource.com/chromium/src/+/08e70dd3bd712e9d57a420c34e98... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/08e70dd3bd712e9d57a420c34e98... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
