MacViews: Don't switch Spaces when calling ShowInactive() for a child Widget.

MacViews: Don't switch Spaces when calling ShowInactive() for a child Widget.

StatusBubbleViews::StatusView could accidentally switch a Space.
It will call Widget::ShowInactive(), which will invoke
[window_ orderWindow:NSWindowAbove relativeTo:parent_window_number],
which will in turn switch the Space (if Chromium is the frontmost
application).

Transient collection behaviour stops NSWindows from triggering this.

BUG=697829
Review-Url: https://codereview.chromium.org/2735723003
Cr-Commit-Position: refs/heads/master@{#455003}
Committed: https://chromium.googlesource.com/chromium/src/+/c4668427a0d5fdd3b376adc871108f14803c6738

[snake, 2017-03-06 18:22:56]

Description was changed from

==========
MacViews: Don't switch Spaces when calling ShowInactive() for a child Widget.

StatusBubbleViews::StatusView could accidentally switch a Space.
It will call Widget::ShowInactive(), which will invoke
[window_ orderWindow:NSWindowAbove relativeTo:parent_window_number],
which will in turn switch the Space (if Chromium is the frontmost
application).

Transient collection behaviour stops NSWindows from triggering this.

BUG=697829
==========

to

==========
MacViews: Don't switch Spaces when calling ShowInactive() for a child Widget.

StatusBubbleViews::StatusView could accidentally switch a Space.
It will call Widget::ShowInactive(), which will invoke
[window_ orderWindow:NSWindowAbove relativeTo:parent_window_number],
which will in turn switch the Space (if Chromium is the frontmost
application).

Transient collection behaviour stops NSWindows from triggering this.

BUG=697829
==========

[snake, 2017-03-06 18:22:56]

art-snake@yandex-team.ru changed reviewers:
+ tapted@chromium.org

[snake, 2017-03-06 18:23:32]

The CQ bit was checked by art-snake@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 18:24:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 18:53:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 18:53:10]

Dry run: This issue passed the CQ dry run.

[snake, 2017-03-06 19:00:58]

MacViews build is waiting the compilation fix:
https://codereview.chromium.org/2737523002/

[tapted, 2017-03-06 22:22:42]

lgtm - thanks!

(I'm assuming you verified manually that NSWindowCollectionBehaviorTransient
does indeed suppress the Spaces switching - I can't think of any way to test
that automatically)

[snake, 2017-03-06 23:54:11]

The CQ bit was checked by art-snake@yandex-team.ru

[commit-bot: I haz the power, 2017-03-06 23:54:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 23:59:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488844451428570, "parent_rev":
"0d7b7b5667f623683dcc42b6c60da2274ab1eb26", "commit_rev":
"c4668427a0d5fdd3b376adc871108f14803c6738"}

[commit-bot: I haz the power, 2017-03-07 00:00:17]

Description was changed from

==========
MacViews: Don't switch Spaces when calling ShowInactive() for a child Widget.

StatusBubbleViews::StatusView could accidentally switch a Space.
It will call Widget::ShowInactive(), which will invoke
[window_ orderWindow:NSWindowAbove relativeTo:parent_window_number],
which will in turn switch the Space (if Chromium is the frontmost
application).

Transient collection behaviour stops NSWindows from triggering this.

BUG=697829
==========

to

==========
MacViews: Don't switch Spaces when calling ShowInactive() for a child Widget.

StatusBubbleViews::StatusView could accidentally switch a Space.
It will call Widget::ShowInactive(), which will invoke
[window_ orderWindow:NSWindowAbove relativeTo:parent_window_number],
which will in turn switch the Space (if Chromium is the frontmost
application).

Transient collection behaviour stops NSWindows from triggering this.

BUG=697829

Review-Url: https://codereview.chromium.org/2735723003
Cr-Commit-Position: refs/heads/master@{#455003}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4668427a0d5fdd3b376adc87110...
==========

[commit-bot: I haz the power, 2017-03-07 00:00:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4668427a0d5fdd3b376adc87110...

[themblsha, 2017-03-07 12:27:58]

On 2017/03/06 22:22:42, tapted wrote:
> lgtm - thanks!
> 
> (I'm assuming you verified manually that NSWindowCollectionBehaviorTransient
> does indeed suppress the Spaces switching - I can't think of any way to test
> that automatically)

Yep, NSWindowCollectionBehaviorTransient worked, but
NSWindowCollectionBehaviorMoveToActiveSpace didn't.