Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2735713002: [heap] Remove ObjectMarking::ClearMarkBit. (Closed)

Created:
3 years, 9 months ago by Hannes Payer (out of office)
Modified:
3 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove ObjectMarking::ClearMarkBit. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2735713002 Cr-Commit-Position: refs/heads/master@{#43610} Committed: https://chromium.googlesource.com/v8/v8/+/8922cabb84cb86a68d51b5650cbcdacc1cbf56f6

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M src/heap/mark-compact.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
ulan
lgtm
3 years, 9 months ago (2017-03-06 10:52:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735713002/1
3 years, 9 months ago (2017-03-06 10:52:43 UTC) #4
commit-bot: I haz the power
Failed to apply patch for src/heap/mark-compact.h: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-06 11:19:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735713002/20001
3 years, 9 months ago (2017-03-06 11:50:44 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 12:18:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/8922cabb84cb86a68d51b5650cbcdacc1cb...

Powered by Google App Engine
This is Rietveld 408576698