Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 2735663002: Introduce isInPasswordField() (Closed)

Created:
3 years, 9 months ago by yosin_UTC9
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce isInPasswordField() This patch Introduces |isInPasswordField()| as a preparation of patch[1] and avoid to use |computeVisibleSelectionInDOMTreeDeprecated()|. [1] http://crrev.com/2734793002: Expand FrameSelection::isInPasswordFiled() into call sites BUG=698633 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2735663002 Cr-Commit-Position: refs/heads/master@{#455018} Committed: https://chromium.googlesource.com/chromium/src/+/08a8136e57f46ee167eef2ff3ffe2667a6ef0174

Patch Set 1 : 2017-03-06T16:21:23 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yosin_UTC9
PTAL
3 years, 9 months ago (2017-03-06 07:46:36 UTC) #5
Xiaocheng
lgtm
3 years, 9 months ago (2017-03-06 18:55:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735663002/1
3 years, 9 months ago (2017-03-07 01:18:20 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 01:26:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08a8136e57f46ee167eef2ff3ffe...

Powered by Google App Engine
This is Rietveld 408576698