third_party/WebKit/Source/core/html/HTMLTextAreaElement.h - Issue 2735633006: INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.h

Issue 2735633006: INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed. (Closed)

Patch Set: Remove throttling Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLTextAreaElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.h b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.h

index 9fd8c06028711d7d57115abd16d64298fe91e31f..6e80038dc1886b4596e8b112f7348d8803444f2f 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.h

@@ -45,7 +45,9 @@ class CORE_EXPORT HTMLTextAreaElement final : public TextControlElement {

String value() const override;

void setValue(const String&,

- TextFieldEventBehavior = DispatchNoEvent) override;

+ TextFieldEventBehavior = DispatchNoEvent,

+ TextControlSetValueSelection =

+ TextControlSetValueSelection::kSetSelectionToEnd) override;

String defaultValue() const;

void setDefaultValue(const String&);

int textLength() const { return value().length(); }

@@ -79,7 +81,9 @@ class CORE_EXPORT HTMLTextAreaElement final : public TextControlElement {

void updateValue() const;

void setInnerEditorValue(const String&) override;

void setNonDirtyValue(const String&);

- void setValueCommon(const String&, TextFieldEventBehavior);

+ void setValueCommon(const String&,

+ TextFieldEventBehavior,

+ TextControlSetValueSelection);

bool isPlaceholderVisible() const override { return m_isPlaceholderVisible; }

void setPlaceholderVisibility(bool) override;