Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2735633006: INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed. (Closed)
Patch Set: Remove throttling Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
index c0e840469d0fd5d7de2f2aa0f7428c810eae0d31..677a9f86819cd94e5a8368f7b80a46ad5fb59109 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
@@ -1071,7 +1071,8 @@ void HTMLInputElement::setValue(const String& value,
}
void HTMLInputElement::setValue(const String& value,
- TextFieldEventBehavior eventBehavior) {
+ TextFieldEventBehavior eventBehavior,
+ TextControlSetValueSelection selection) {
m_inputType->warnIfValueIsInvalidAndElementIsVisible(value);
if (!m_inputType->canSetValue(value))
return;
@@ -1085,7 +1086,7 @@ void HTMLInputElement::setValue(const String& value,
// Prevent TextFieldInputType::setValue from using the suggested value.
m_suggestedValue = String();
- m_inputType->setValue(sanitizedValue, valueChanged, eventBehavior);
+ m_inputType->setValue(sanitizedValue, valueChanged, eventBehavior, selection);
m_inputTypeView->didSetValue(sanitizedValue, valueChanged);
if (valueChanged)
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.h ('k') | third_party/WebKit/Source/core/html/HTMLTextAreaElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698