third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.h - Issue 2735633006: INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.h

Issue 2735633006: INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.h

diff --git a/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.h b/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.h

index 630c742155e304c7bfee3ab6946c57918f26c5dc..b4614a217f1e9d24f02acd5f7c73513b00c9da08 100644

--- a/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.h

+++ b/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.h

@@ -61,7 +61,10 @@ class BaseCheckableInputType : public InputType, public InputTypeView {

void accessKeyAction(bool sendMouseEvents) final;

bool matchesDefaultPseudoClass() override;

ValueMode valueMode() const override;

- void setValue(const String&, bool, TextFieldEventBehavior) final;

+ void setValue(const String&,

+ bool,

+ TextFieldEventBehavior,

+ TextControlSetValueSelection) final;

void readingChecked() const final;

bool isCheckable() final;

bool shouldDispatchFormControlChangeEvent(String&, String&) override;