third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp - Issue 2735633006: INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp

Issue 2735633006: INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/TextControlElement.h ('K') | « third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.h ('k') | third_party/WebKit/Source/core/html/forms/FileInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp b/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp

index 3c5ccf2421573fb39992480ead4462d1a37f81b5..d2e393ec4d1fb4cc36845eea8568d29c4f3681c9 100644

--- a/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp

@@ -104,7 +104,8 @@ InputType::ValueMode BaseCheckableInputType::valueMode() const {

void BaseCheckableInputType::setValue(const String& sanitizedValue,

bool,

- TextFieldEventBehavior) {

+ TextFieldEventBehavior,

+ TextControlSetValueSelection) {

element().setAttribute(valueAttr, AtomicString(sanitizedValue));

}