Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2735603002:
Call delay_show Cancel in ScrollbarAnimationControlller::Show (Closed)
DescriptionCall delay_show Cancel in ScrollbarAnimationControlller::Show
This issue is caused by TaskRunner not set delay event cancel after execute. So
we need to call Cancel manually on ScrollbarAnimationControlller::Show.
We also add a Cancel in ScrollbarAnimationControlller::DidMouseLeave.
BUG=698352
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2735603002
Cr-Commit-Position: refs/heads/master@{#455125}
Committed: https://chromium.googlesource.com/chromium/src/+/56c267d43381c48f5fc1d1acf43550e2cd3e759a
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 29 (18 generated)
Description was changed from ========== Call delay_show Cancel in ScrollbarAnimationControlller::Show This issue is caused by TaskRunner not set delay event cancel after execute. So we need to call Cancel manually on ScrollbarAnimationControlller::Show. We also add a Cancel in ScrollbarAnimationControlller::DidMouseLeave. BUG=698352 ========== to ========== Call delay_show Cancel in ScrollbarAnimationControlller::Show This issue is caused by TaskRunner not set delay event cancel after execute. So we need to call Cancel manually on ScrollbarAnimationControlller::Show. We also add a Cancel in ScrollbarAnimationControlller::DidMouseLeave. BUG=698352 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
Description was changed from ========== Call delay_show Cancel in ScrollbarAnimationControlller::Show This issue is caused by TaskRunner not set delay event cancel after execute. So we need to call Cancel manually on ScrollbarAnimationControlller::Show. We also add a Cancel in ScrollbarAnimationControlller::DidMouseLeave. BUG=698352 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Call delay_show Cancel in ScrollbarAnimationControlller::Show This issue is caused by TaskRunner not set delay event cancel after execute. So we need to call Cancel manually on ScrollbarAnimationControlller::Show. We also add a Cancel in ScrollbarAnimationControlller::DidMouseLeave. BUG=698352 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
chaopeng@chromium.org changed reviewers: + bokan@chromium.org
The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL. Thank you.
lgtm
chaopeng@chromium.org changed reviewers: + weiliangc@chromium.org
weiliangc@chromium.org: PTAL. Thank you.
LGTM
The CQ bit was checked by chaopeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by chaopeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by chaopeng@chromium.org
The CQ bit was checked by chaopeng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org, weiliangc@chromium.org Link to the patchset: https://codereview.chromium.org/2735603002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by chaopeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488901772936870,
"parent_rev": "a5129e7d6f46b41c6d8e7859940afdafc80b21dd", "commit_rev":
"56c267d43381c48f5fc1d1acf43550e2cd3e759a"}
Message was sent while issue was closed.
Description was changed from ========== Call delay_show Cancel in ScrollbarAnimationControlller::Show This issue is caused by TaskRunner not set delay event cancel after execute. So we need to call Cancel manually on ScrollbarAnimationControlller::Show. We also add a Cancel in ScrollbarAnimationControlller::DidMouseLeave. BUG=698352 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Call delay_show Cancel in ScrollbarAnimationControlller::Show This issue is caused by TaskRunner not set delay event cancel after execute. So we need to call Cancel manually on ScrollbarAnimationControlller::Show. We also add a Cancel in ScrollbarAnimationControlller::DidMouseLeave. BUG=698352 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2735603002 Cr-Commit-Position: refs/heads/master@{#455125} Committed: https://chromium.googlesource.com/chromium/src/+/56c267d43381c48f5fc1d1acf435... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/56c267d43381c48f5fc1d1acf435... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
