Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2735363002: [ia32] Fix invalid DCHECK on cmpw with immediate. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Fix invalid DCHECK on cmpw with immediate. The immediate passed to cmpw can be either a signed 16-bit or an unsigned 16-bit integer, but the DCHECK was testing for signed 16-bit values only. R=mstarzinger@chromium.org BUG=v8:6063 Review-Url: https://codereview.chromium.org/2735363002 Cr-Commit-Position: refs/heads/master@{#43671} Committed: https://chromium.googlesource.com/v8/v8/+/65607079453a9485e8bcc3902029a178f0b6f238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/ia32/assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-6063.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-08 12:38:47 UTC) #1
Michael Starzinger
LGTM.
3 years, 9 months ago (2017-03-08 12:40:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735363002/1
3 years, 9 months ago (2017-03-08 12:40:53 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 13:04:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/65607079453a9485e8bcc3902029a178f0b...

Powered by Google App Engine
This is Rietveld 408576698