Rename *isOverWidget* methods to ...isOverFrameViewBase...

third_party/WebKit/Source/core/input/ScrollManager.h

Index: third_party/WebKit/Source/core/input/ScrollManager.h
diff --git a/third_party/WebKit/Source/core/input/ScrollManager.h b/third_party/WebKit/Source/core/input/ScrollManager.h
index 51fbc7b855cec6e37b0f8ad1bf310870fcea2955..056d1b757dfdb828e5097cda0ea7101991368494 100644
--- a/third_party/WebKit/Source/core/input/ScrollManager.h
+++ b/third_party/WebKit/Source/core/input/ScrollManager.h
@@ -95,8 +95,9 @@ class CORE_EXPORT ScrollManager
   WebInputEventResult handleGestureScrollUpdate(const WebGestureEvent&);
   WebInputEventResult handleGestureScrollBegin(const WebGestureEvent&);
 
-  WebInputEventResult passScrollGestureEventToWidget(const WebGestureEvent&,
-                                                     LayoutObject*);
+  WebInputEventResult passScrollGestureEventToFrameViewBase(

[haraken, 2017/03/08 06:19:06]

Maybe we could drop "ToFrameViewBase" to make it less verbose.

[joelhockey, 2017/03/08 06:42:36]

Done.  Yes, the parameters make it clear enought that the gesture is being
passed to
LayoutObject / LayoutPart / FrameViewBase.

+      const WebGestureEvent&,
+      LayoutObject*);
 
   void clearGestureScrollState();
 
@@ -121,7 +122,7 @@ class CORE_EXPORT ScrollManager
 
   Member<Node> m_scrollGestureHandlingNode;
 
-  bool m_lastGestureScrollOverWidget;
+  bool m_lastGestureScrollOverFrameViewBase;

[haraken, 2017/03/08 06:19:06]

Maybe drop "OverFrameViewBase".

[joelhockey, 2017/03/08 06:42:36]

I'll leave this for now.  I did think about making it shorter, but I judged that
anything shorter becomes ambiguous and so even though this is a long name, it
did help me understand the code.

 
   // The most recent element to scroll natively during this scroll
   // sequence. Null if no native element has scrolled this scroll