Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2735233004:
Remove HarfBuzz version specific compile conditional (Closed)
|
Created:
3 years, 9 months ago by drott Modified:
3 years, 8 months ago Reviewers:
jungshik at Google CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vapier Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove HarfBuzz version specific compile conditional
BUG=696570
TBR=jshin
Review-Url: https://codereview.chromium.org/2735233004
Cr-Commit-Position: refs/heads/master@{#460137}
Committed: https://chromium.googlesource.com/chromium/src/+/ed7d4f727ec41f735788d6096dbe4b45f7f54279
Patch Set 1 #
Messages
Total messages: 26 (19 generated)
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove HarfBuzz version specific compile conditional BUG=696570 ========== to ========== Remove HarfBuzz version specific compile conditional BUG=696570 TBR=jshin ==========
drott@chromium.org changed reviewers: + jshin@chromium.org
The CQ bit was unchecked by drott@chromium.org
The CQ bit was checked by drott@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
On 2017/03/08 10:11:01, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromeos_amd64-generic_chromium_compile_only_ng on > master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) Hmm... it's odd that CrOS bots failed even though HarfBuzz was updated to 1.4.2 on CrOS on Feb 25.
Description was changed from ========== Remove HarfBuzz version specific compile conditional BUG=696570 TBR=jshin ========== to ========== Remove HarfBuzz version specific compile conditional BUG=696570 TBR=jshin ==========
On 2017/03/08 10:57:58, jungshik at Google wrote: > On 2017/03/08 10:11:01, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > chromeos_amd64-generic_chromium_compile_only_ng on > > master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) > > Hmm... it's odd that CrOS bots failed even though HarfBuzz was updated to 1.4.2 > on CrOS on Feb 25. Mike, the include line has the following: /b/c/b/chromeos_amd64_generic_chromium_compile_only_ng/.cros_cache/chrome-sdk/tarballs/amd64-generic+9282.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/harfbuzz cros_cache/chrome-sdk/tarballs/... is stale / out-dated? If so, how can it be updated?
On 2017/03/08 at 11:08:32, jshin wrote: Let's continue the discussion in https://crbug.com/699525
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by drott@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490712792467680, "parent_rev":
"c4ab0d4f781754dc5943214f14f551cc1286c772", "commit_rev":
"ed7d4f727ec41f735788d6096dbe4b45f7f54279"}
Message was sent while issue was closed.
Description was changed from ========== Remove HarfBuzz version specific compile conditional BUG=696570 TBR=jshin ========== to ========== Remove HarfBuzz version specific compile conditional BUG=696570 TBR=jshin Review-Url: https://codereview.chromium.org/2735233004 Cr-Commit-Position: refs/heads/master@{#460137} Committed: https://chromium.googlesource.com/chromium/src/+/ed7d4f727ec41f735788d6096dbe... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ed7d4f727ec41f735788d6096dbe... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
