Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2735233002: MD Settings Fix RTL for network list items (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam, hcarmona
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings Fix RTL for network list items BUG=698896 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2735233002 Cr-Commit-Position: refs/heads/master@{#455258} Committed: https://chromium.googlesource.com/chromium/src/+/c2c4507a33a1f95eeb9265a3de0344704b1170d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/webui/resources/cr_elements/network/cr_network_list_item.html View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
stevenjb
3 years, 9 months ago (2017-03-07 19:58:47 UTC) #3
stevenjb
Screenshot with fixes in issue and here: https://screenshot.googleplex.com/ur86DVe3v3O.png
3 years, 9 months ago (2017-03-07 20:04:23 UTC) #4
Dan Beam
lgtm but i don't really see why having multiple components (#id and tag) and a ...
3 years, 9 months ago (2017-03-07 20:07:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735233002/1
3 years, 9 months ago (2017-03-07 20:38:09 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 22:37:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2c4507a33a1f95eeb9265a3de03...

Powered by Google App Engine
This is Rietveld 408576698