content/test/test_render_frame_host.cc - Issue 2735183003: PlzNavigate: stop navigations when opening a document for write

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_render_frame_host.cc

Issue 2735183003: PlzNavigate: stop navigations when opening a document for write (Closed)

Patch Set: Rebase + fixed compilation error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/test_render_frame_host.cc

diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc

index ee77d73a26dcdc05d4b5a54482f10d1c480c3045..5159d4b503509b4d5fd8661f9d520fffbbbb7194 100644

--- a/content/test/test_render_frame_host.cc

+++ b/content/test/test_render_frame_host.cc

@@ -235,7 +235,7 @@ void TestRenderFrameHost::SimulateNavigationStop() {

} else if (IsBrowserSideNavigationEnabled()) {

// Even if the RenderFrameHost is not loading, there may still be an

// ongoing navigation in the FrameTreeNode. Cancel this one as well.

- frame_tree_node()->ResetNavigationRequest(false);

+ frame_tree_node()->ResetNavigationRequest(false, true);

}