Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: content/browser/frame_host/navigator.h

Issue 2735183003: PlzNavigate: stop navigations when opening a document for write (Closed)
Patch Set: Rebase + fixed compilation error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index 5f0a059a79ce0a2c4f7b3e8337b040dc5f32baed..cf524e533a311ebc5ac6cef6375da2ce4a6096bf 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -157,9 +157,16 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
const BeginNavigationParams& begin_params);
// PlzNavigate
- // Cancel a NavigationRequest for |frame_tree_node|. Called when
- // |frame_tree_node| is destroyed.
- virtual void CancelNavigation(FrameTreeNode* frame_tree_node) {}
+ // Used to abort an ongoing renderer-initiated navigation.
+ virtual void OnAbortNavigation(FrameTreeNode* frame_tree_node) {}
+
+ // PlzNavigate
+ // Cancel a NavigationRequest for |frame_tree_node|. If the request is
+ // renderer-initiated and |inform_renderer| is true, an IPC will be sent to
+ // the renderer process to inform it that the navigation it request was
Charlie Reis 2017/03/22 23:54:41 nit: requested
clamy 2017/03/23 13:17:52 Done.
+ // cancelled.
+ virtual void CancelNavigation(FrameTreeNode* frame_tree_node,
+ bool inform_renderer) {}
// Called when the network stack started handling the navigation request
// so that the |timestamp| when it happened can be recorded into an histogram.

Powered by Google App Engine
This is Rietveld 408576698