Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: third_party/WebKit/Source/core/editing/GranularityStrategy.h

Issue 2735143002: Make GranularityStrategy::updateExtent() to return SelectionInDOM instead of VisibleSelection (Closed)
Patch Set: 2017-03-09T16:45:24 rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/GranularityStrategy.h
diff --git a/third_party/WebKit/Source/core/editing/GranularityStrategy.h b/third_party/WebKit/Source/core/editing/GranularityStrategy.h
index e93b29d8d02e7c6610a27b44970dd9ec6e02ca7a..5377c959241d5b1c4f36a00c10af50f621baebb3 100644
--- a/third_party/WebKit/Source/core/editing/GranularityStrategy.h
+++ b/third_party/WebKit/Source/core/editing/GranularityStrategy.h
@@ -6,7 +6,7 @@
#define GranularityStrategy_h
#include "core/editing/SelectionStrategy.h"
-#include "core/editing/VisibleSelection.h"
+#include "core/editing/SelectionTemplate.h"
#include "wtf/Allocator.h"
namespace blink {
@@ -21,7 +21,7 @@ class GranularityStrategy {
// Calculates and returns the new selection based on the updated extent
// location in absolute coordinates.
- virtual VisibleSelection updateExtent(const IntPoint&, LocalFrame*) = 0;
+ virtual SelectionInDOMTree updateExtent(const IntPoint&, LocalFrame*) = 0;
protected:
GranularityStrategy();
@@ -36,7 +36,7 @@ class CharacterGranularityStrategy final : public GranularityStrategy {
// GranularityStrategy:
SelectionStrategy GetType() const final;
void Clear() final;
- VisibleSelection updateExtent(const IntPoint&, LocalFrame*) final;
+ SelectionInDOMTree updateExtent(const IntPoint&, LocalFrame*) final;
};
// "Expand by word, shrink by character" selection strategy.
@@ -84,7 +84,7 @@ class DirectionGranularityStrategy final : public GranularityStrategy {
// GranularityStrategy:
SelectionStrategy GetType() const final;
void Clear() final;
- VisibleSelection updateExtent(const IntPoint&, LocalFrame*) final;
+ SelectionInDOMTree updateExtent(const IntPoint&, LocalFrame*) final;
private:
enum class StrategyState {

Powered by Google App Engine
This is Rietveld 408576698