Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2735143002: Make GranularityStrategy::updateExtent() to return SelectionInDOM instead of VisibleSelection (Closed)
Patch Set: 2017-03-09T16:45:24 rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/GranularityStrategy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index 03148bbd7cb508b7361178b61f323504a17cf2ac..e50140b8ba737491dda3a87659442089c3c2a384 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -1092,14 +1092,14 @@ void FrameSelection::moveRangeSelectionExtent(const IntPoint& contentsPoint) {
if (computeVisibleSelectionInDOMTreeDeprecated().isNone())
return;
- VisibleSelection newSelection =
- granularityStrategy()->updateExtent(contentsPoint, m_frame);
- setSelection(SelectionInDOMTree::Builder(newSelection.asSelection())
+ const SetSelectionOptions options =
+ FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle |
+ FrameSelection::DoNotClearStrategy | UserTriggered;
+ setSelection(SelectionInDOMTree::Builder(
+ granularityStrategy()->updateExtent(contentsPoint, m_frame))
.setIsHandleVisible(true)
.build(),
- FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle |
- FrameSelection::DoNotClearStrategy | UserTriggered,
- CursorAlignOnScroll::IfNeeded, CharacterGranularity);
+ options);
}
// TODO(yosin): We should make |FrameSelection::moveRangeSelection()| to take
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/GranularityStrategy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698