Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2735133004: DevTools coverage: get script/stylesheet size directly, do not request content (Closed)

Created:
3 years, 9 months ago by caseq
Modified:
3 years, 9 months ago
Reviewers:
kozy, alph
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools coverage: get script/stylesheet size directly, do not request content This utilizes length of scripts and stylesheets recently exposed in the protocolto avoid requesting content in CoverageModel. Review-Url: https://codereview.chromium.org/2735133004 Cr-Commit-Position: refs/heads/master@{#455761} Committed: https://chromium.googlesource.com/chromium/src/+/a2c7947c0fe5075433308db8d281b5c0230c0864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -80 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js View 6 chunks +19 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 4 chunks +17 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Script.js View 2 chunks +6 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
caseq
3 years, 9 months ago (2017-03-08 21:44:58 UTC) #3
alph
lgtm
3 years, 9 months ago (2017-03-09 00:49:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735133004/1
3 years, 9 months ago (2017-03-09 00:50:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/336757)
3 years, 9 months ago (2017-03-09 01:35:00 UTC) #9
kozy
lgtm
3 years, 9 months ago (2017-03-09 16:01:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735133004/1
3 years, 9 months ago (2017-03-09 16:03:08 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 16:29:16 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2c7947c0fe5075433308db8d281...

Powered by Google App Engine
This is Rietveld 408576698