Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2735133003: [Cleanup] Run git cl format on minidump uploader files. (Closed)

Created:
3 years, 9 months ago by Ilya Sherman
Modified:
3 years, 9 months ago
Reviewers:
Maria
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Run git cl format on minidump uploader files. BUG=694884 TEST=none R=mariakhomenko@chromium.org Review-Url: https://codereview.chromium.org/2735133003 Cr-Commit-Position: refs/heads/master@{#455412} Committed: https://chromium.googlesource.com/chromium/src/+/5b444f201a0e88282af902010b5c29c808c4fadc

Patch Set 1 #

Patch Set 2 : Manually revert questionable changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -157 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 1 5 chunks +7 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java View 6 chunks +37 lines, -47 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationCallable.java View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationService.java View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java View 1 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java View 1 15 chunks +23 lines, -38 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java View 4 chunks +8 lines, -8 lines 0 comments Download
M components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java View 1 6 chunks +5 lines, -10 lines 0 comments Download
M components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java View 1 3 chunks +7 lines, -8 lines 0 comments Download
M components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/HttpURLConnectionFactoryImpl.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Ilya Sherman
3 years, 9 months ago (2017-03-08 02:31:28 UTC) #1
Maria
lgtm
3 years, 9 months ago (2017-03-08 04:17:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735133003/20001
3 years, 9 months ago (2017-03-08 09:10:35 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 09:15:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b444f201a0e88282af902010b5c...

Powered by Google App Engine
This is Rietveld 408576698