Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Issue 2735073002: Downloads service foreground on N (Closed)

Created:
3 years, 9 months ago by David Trainor- moved to gerrit
Modified:
3 years, 9 months ago
Reviewers:
qinmin
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Downloads service foreground on N Make downloads work as a foreground service on Android versions >= N. BUG=680819 Review-Url: https://codereview.chromium.org/2735073002 Cr-Commit-Position: refs/heads/master@{#455124} Committed: https://chromium.googlesource.com/chromium/src/+/a5129e7d6f46b41c6d8e7859940afdafc80b21dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 10 chunks +17 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java View 3 chunks +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
David Trainor- moved to gerrit
min ptal thanks!
3 years, 9 months ago (2017-03-07 00:57:55 UTC) #3
qinmin
lgtm
3 years, 9 months ago (2017-03-07 07:16:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735073002/1
3 years, 9 months ago (2017-03-07 17:25:14 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 17:51:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a5129e7d6f46b41c6d8e7859940a...

Powered by Google App Engine
This is Rietveld 408576698