Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issue 2735063005: s/isSamePage/isSameDocument in ContentViewCore.didFinishNavigation. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
Reviewers:
clamy
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

s/isSamePage/isSameDocument in ContentViewCore.didFinishNavigation. Follow up cleanup after https://codereview.chromium.org/2716493004/ BUG=695189 Review-Url: https://codereview.chromium.org/2735063005 Cr-Commit-Position: refs/heads/master@{#455757} Committed: https://chromium.googlesource.com/chromium/src/+/59ab7a2000a72a8d7ec9467672d6636683c62622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 9 months ago (2017-03-07 19:56:05 UTC) #6
clamy
Thanks! Lgtm.
3 years, 9 months ago (2017-03-09 13:42:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735063005/1
3 years, 9 months ago (2017-03-09 15:32:34 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 16:21:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/59ab7a2000a72a8d7ec9467672d6...

Powered by Google App Engine
This is Rietveld 408576698