Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2734983004: cc: Add a helper function for transforming rects between surface spaces (Closed)

Created:
3 years, 9 months ago by jaydasika
Modified:
3 years, 9 months ago
Reviewers:
ajuma, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add a helper function for transforming rects between surface spaces And use it everywhere we convert rects in draw_property_utils.cc between surface spaces. Using this helper function also fixes a bug in caclulating render surface's clip rect. BUG=663309 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2734983004 Cr-Commit-Position: refs/heads/master@{#455222} Committed: https://chromium.googlesource.com/chromium/src/+/44b074ebba30c2f7c20c70f6a3a6a95ebc341037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -87 lines) Patch
M cc/trees/draw_property_utils.cc View 6 chunks +61 lines, -86 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
jaydasika
PTAL
3 years, 9 months ago (2017-03-07 01:32:26 UTC) #5
weiliangc
LGTM
3 years, 9 months ago (2017-03-07 15:39:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734983004/1
3 years, 9 months ago (2017-03-07 18:39:16 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 21:12:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/44b074ebba30c2f7c20c70f6a3a6...

Powered by Google App Engine
This is Rietveld 408576698