Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2734983002: [Merge M57] arc: Handle metrics for Auth operations. (Closed)

Created:
3 years, 9 months ago by khmel
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge M57] arc: Handle metrics for Auth operations. This handles messages with Auth operation metrics and add it to UMA. TEST=Locally, new metrics appear in chrome://histograms BUG=b/35707115 BUG=695542 TBR=dcheng@chromium.org,lhchavez@chromium.org,isherman@chromium.org NOTRY=true NOPRESUBMIT=true Approval at b/35707115 Review-Url: https://codereview.chromium.org/2704383006 Cr-Commit-Position: refs/heads/master@{#452722} (cherry picked from commit 052c11832f70f11fb220abb005bcf93143d2e4e8) Review-Url: https://codereview.chromium.org/2734983002 Cr-Commit-Position: refs/branch-heads/2987@{#784} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/7b108ffe5ed8ba43eeb472fc4a20a567a0cebb2b

Patch Set 1 #

Patch Set 2 : fix merge conflict/manually tested with/without android changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -2 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_optin_uma.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_optin_uma.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
M components/arc/common/auth.mojom View 1 4 chunks +22 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734983002/20001
3 years, 9 months ago (2017-03-07 15:51:37 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 15:56:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7b108ffe5ed8ba43eeb472fc4a20...

Powered by Google App Engine
This is Rietveld 408576698