Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2734943004: DevTools: Fix previous cookie selection (Closed)

Created:
3 years, 9 months ago by phulce
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix previous cookie selection * Fixes issue where the previous cookie would not be selected if selection was at the bottom of the table. BUG=694741 Review-Url: https://codereview.chromium.org/2734943004 Cr-Commit-Position: refs/heads/master@{#455485} Committed: https://chromium.googlesource.com/chromium/src/+/1a3ea6d2b334319300f45f1bc74b9db0de0e7d67

Patch Set 1 #

Patch Set 2 : premature upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
phulce
3 years, 9 months ago (2017-03-07 17:53:30 UTC) #2
dgozman
lgtm
3 years, 9 months ago (2017-03-07 20:09:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734943004/20001
3 years, 9 months ago (2017-03-07 23:47:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/378858)
3 years, 9 months ago (2017-03-08 01:15:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734943004/20001
3 years, 9 months ago (2017-03-08 16:30:07 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 17:43:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a3ea6d2b334319300f45f1bc74b...

Powered by Google App Engine
This is Rietveld 408576698