More support for generic function types

More support for generic function types

[Brian Wilkerson, 2017-03-06 19:58:06]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com, scheglov@google.com

[Brian Wilkerson, 2017-03-06 19:58:07]

I'm not thrilled with this. I originally tried not creating an element for a
generic function type, but we need it in order to have a parent for the type
parameters and the formal parameters. Then I tried re-using
FunctionTypeAliasElementImpl rather than create another implementation of
FunctionTypeElement, but having some fields that were used in one case and other
fields used in another case got confusing. If you can think of a better
approach, please let me know.

https://codereview.chromium.org/2734943002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2734943002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:4969: _function = type.element;
Will this work? If we synthesize a type will it have an element associated with
it? Or do I need to make the generic function type's element of child of the
typedef?

[Paul Berry, 2017-03-06 20:21:15]

lgtm

https://codereview.chromium.org/2734943002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2734943002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:4969: _function = type.element;
On 2017/03/06 19:58:07, Brian Wilkerson wrote:
> Will this work? If we synthesize a type will it have an element associated
with
> it? Or do I need to make the generic function type's element of child of the
> typedef?

I confess that I don't know off the top of my head.  I think the best way to
answer the question is to write a unit test that validates that the correct
structure gets resynthesized.

[scheglov, 2017-03-06 20:22:22]

lgtm

https://codereview.chromium.org/2734943002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2734943002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:4969: _function = type.element;
On 2017/03/06 19:58:07, Brian Wilkerson wrote:
> Will this work? If we synthesize a type will it have an element associated
with
> it? Or do I need to make the generic function type's element of child of the
> typedef?

I think so.
If it does not have the corresponding element, then this is a bug.

[Brian Wilkerson, 2017-03-06 22:27:02]

https://codereview.chromium.org/2734943002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2734943002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:4969: _function = type.element;
Thanks! I'm going to go ahead and commit this. I'm not quite far enough along in
other areas to be able to serialize and deserialize these elements, but once
it's possible there will definitely be tests.

[Brian Wilkerson, 2017-03-07 16:05:39]

Somehow things got messed up on my machine and the connection between my git
branch and this CL was lost. I re-uploaded and committed exactly the same
changes, but without a second review.

[Paul Berry, 2017-03-07 16:42:28]

On 2017/03/07 16:05:39, Brian Wilkerson wrote:
> Somehow things got messed up on my machine and the connection between my git
> branch and this CL was lost. I re-uploaded and committed exactly the same
> changes, but without a second review.

In case anyone is looking for it, the follow-up CL is here:
https://codereview.chromium.org/2736643006
And the final commit is:
https://github.com/dart-lang/sdk/commit/0fa6715bd8d46e55846e26e47007695783df4415