Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2734933003: Enable WebUSB device detection when using the new Windows USB backend. (Closed)

Created:
3 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
juncai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable WebUSB device detection when using the new Windows USB backend. One of the goals of the new USB backend on Windows is to resolve the issue of Chrome getting stuck in blocking USB ioctls inside libusb so let's re-enable WebUSB device detection when running with the new backend enabled (which is so far disabled by default). BUG=652416 Review-Url: https://codereview.chromium.org/2734933003 Cr-Commit-Position: refs/heads/master@{#455157} Committed: https://chromium.googlesource.com/chromium/src/+/76a2fa3cf40ee87f63d123c131b5ef5f15cdd7a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/usb/web_usb_detector.cc View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Reilly Grant (use Gerrit)
ptal
3 years, 9 months ago (2017-03-07 01:25:10 UTC) #3
juncai
LGTM.
3 years, 9 months ago (2017-03-07 18:00:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734933003/1
3 years, 9 months ago (2017-03-07 18:30:29 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 18:48:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76a2fa3cf40ee87f63d123c131b5...

Powered by Google App Engine
This is Rietveld 408576698