Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2734923002: Add LayoutOpportunityIterator method to NGConstraintSpace (Closed)

Created:
3 years, 9 months ago by Gleb Lanbin
Modified:
3 years, 9 months ago
Reviewers:
cbiesinger, ikilpatrick
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add LayoutOpportunityIterator method to NGConstraintSpace LayoutOpportunityIterator method returns a default layout opportunity iterator that starts from NGConstraintSpace::BfcOffset. It's invalidated when a new exclusion is added. Usage example: NGInlineBuilder needs to iterate over available opportunities. BUG=635619 Review-Url: https://codereview.chromium.org/2734923002 Cr-Commit-Position: refs/heads/master@{#455220} Committed: https://chromium.googlesource.com/chromium/src/+/b5f30def1f14944ea1d342b99c2afcd693a31278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 4 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Gleb Lanbin
3 years, 9 months ago (2017-03-06 20:22:06 UTC) #2
cbiesinger
lgtm
3 years, 9 months ago (2017-03-07 18:52:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734923002/1
3 years, 9 months ago (2017-03-07 19:05:10 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 21:09:39 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5f30def1f14944ea1d342b99c2a...

Powered by Google App Engine
This is Rietveld 408576698