A/B fasta performance measurement harness

A/B fasta performance measurement harness

Tweak and reapply https://codereview.chromium.org/2731703003/

Committed: https://github.com/dart-lang/sdk/commit/c354e26fb634f83c81daf654e464b6106de19c7a

[danrubel, 2017-03-06 19:30:02]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[danrubel, 2017-03-06 19:30:53]

Description was changed from

==========
A/B fasta performance measurement harness

Tweak and reapply https://codereview.chromium.org/2731703003/
==========

to

==========
A/B fasta performance measurement harness

Tweak and reapply https://codereview.chromium.org/2731703003/

Committed:
https://github.com/dart-lang/sdk/commit/c354e26fb634f83c81daf654e464b6106de19c7a
==========

[danrubel, 2017-03-06 19:30:55]

Committed patchset #2 (id:20001) manually as
c354e26fb634f83c81daf654e464b6106de19c7a (presubmit successful).

[Paul Berry, 2017-03-06 20:27:40]

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
File pkg/front_end/tool/fasta/compile.dart (right):

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
pkg/front_end/tool/fasta/compile.dart:30: if (elapseTimes.length < 4) {
This should be 5.  We need to ensure that at least two values are sent to the
standardDeviation() function, or it will divide by zero.

[ahe, 2017-03-07 14:03:25]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-03-07 14:03:25]

Code in bin/ and tool/ can't be tested and shared, can we move it to
lib/src/fasta/something?

[ahe, 2017-03-07 14:04:02]

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
File pkg/front_end/tool/fasta/abcompile.dart (right):

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
pkg/front_end/tool/fasta/abcompile.dart:1: import 'dart:async';
Missing copyright.

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
File pkg/front_end/tool/fasta/standard_deviation.dart (right):

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
pkg/front_end/tool/fasta/standard_deviation.dart:1: import 'dart:math';
Missing copyright.

[danrubel, 2017-03-09 01:58:45]

On 2017/03/07 14:03:25, ahe wrote:
> Code in bin/ and tool/ can't be tested and shared, can we move it to
> lib/src/fasta/something?

Moved compile.dart functionality into outline.dart as per our discussion.
See https://codereview.chromium.org/2739963002

[danrubel, 2017-03-09 02:01:01]

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
File pkg/front_end/tool/fasta/abcompile.dart (right):

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
pkg/front_end/tool/fasta/abcompile.dart:1: import 'dart:async';
On 2017/03/07 14:04:02, ahe wrote:
> Missing copyright.

Fixed. https://codereview.chromium.org/2739963002

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
File pkg/front_end/tool/fasta/compile.dart (right):

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
pkg/front_end/tool/fasta/compile.dart:30: if (elapseTimes.length < 4) {
On 2017/03/06 20:27:40, Paul Berry wrote:
> This should be 5.  We need to ensure that at least two values are sent to the
> standardDeviation() function, or it will divide by zero.

Good point. Addressed in https://codereview.chromium.org/2739963002

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
File pkg/front_end/tool/fasta/standard_deviation.dart (right):

https://codereview.chromium.org/2734863003/diff/20001/pkg/front_end/tool/fast...
pkg/front_end/tool/fasta/standard_deviation.dart:1: import 'dart:math';
On 2017/03/07 14:04:02, ahe wrote:
> Missing copyright.

Fixed. https://codereview.chromium.org/2739963002/