Default background for not suggested article images

Default background for suggested article images

This CL adds a uniform grey background for the suggested articles' image,
which is displayed until a fetched image is displayed.

BUG=698171
Review-Url: https://codereview.chromium.org/2734763003
Cr-Commit-Position: refs/heads/master@{#454884}
Committed: https://chromium.googlesource.com/chromium/src/+/99ee0570b40f1e61e27a35d8b41c52e892e0fd01

[gambard, 2017-03-06 12:21:42]

Description was changed from

==========
Grey background for not downloaded suggestions images

This CL adds a uniform grey background for the suggested articles' image,
which is displayed until a fetched image is displayed.

BUG=698171
==========

to

==========
Default background for not suggested article images

This CL adds a uniform grey background for the suggested articles' image,
which is displayed until a fetched image is displayed.

BUG=698171
==========

[gambard, 2017-03-06 12:21:53]

Description was changed from

==========
Default background for not suggested article images

This CL adds a uniform grey background for the suggested articles' image,
which is displayed until a fetched image is displayed.

BUG=698171
==========

to

==========
Default background for suggested article images

This CL adds a uniform grey background for the suggested articles' image,
which is displayed until a fetched image is displayed.

BUG=698171
==========

[gambard, 2017-03-06 12:22:13]

gambard@chromium.org changed reviewers:
+ jif@chromium.org

[gambard, 2017-03-06 12:22:14]

PTAL.

[jif, 2017-03-06 13:23:05]

lgtm

[gambard, 2017-03-06 13:23:26]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2017-03-06 13:23:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jif, 2017-03-06 13:25:38]

Note:
If you want to go the extra mile (in a different CL), you can move
|UIImageWithSizeAndSolidColor| into a non-test-specific file, and use that
helper to implement emptyImageBackground.
I think there's a bunch of other places where we could use that helper.

[commit-bot: I haz the power, 2017-03-06 13:52:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 13:52:51]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gambard, 2017-03-06 17:30:35]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-03-06 17:30:35]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org
Link to the patchset: https://codereview.chromium.org/2734763003/#ps20001
(title: "Fix tests")

[commit-bot: I haz the power, 2017-03-06 17:30:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gambard, 2017-03-06 17:31:00]

On 2017/03/06 13:25:38, jif wrote:
> Note:
> If you want to go the extra mile (in a different CL), you can move
> |UIImageWithSizeAndSolidColor| into a non-test-specific file, and use that
> helper to implement emptyImageBackground.
> I think there's a bunch of other places where we could use that helper.

This method should be removed soon, so I don't think it is worth.

[commit-bot: I haz the power, 2017-03-06 18:01:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488821435216170,
"parent_rev": "4ff77a6cf88f3a5d793eabb02bd62d61f8dd4b1f", "commit_rev":
"99ee0570b40f1e61e27a35d8b41c52e892e0fd01"}

[commit-bot: I haz the power, 2017-03-06 18:02:21]

Description was changed from

==========
Default background for suggested article images

This CL adds a uniform grey background for the suggested articles' image,
which is displayed until a fetched image is displayed.

BUG=698171
==========

to

==========
Default background for suggested article images

This CL adds a uniform grey background for the suggested articles' image,
which is displayed until a fetched image is displayed.

BUG=698171

Review-Url: https://codereview.chromium.org/2734763003
Cr-Commit-Position: refs/heads/master@{#454884}
Committed:
https://chromium.googlesource.com/chromium/src/+/99ee0570b40f1e61e27a35d8b41c...
==========

[commit-bot: I haz the power, 2017-03-06 18:02:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/99ee0570b40f1e61e27a35d8b41c...