Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2734763003: Default background for not suggested article images (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
jif
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Default background for suggested article images This CL adds a uniform grey background for the suggested articles' image, which is displayed until a fetched image is displayed. BUG=698171 Review-Url: https://codereview.chromium.org/2734763003 Cr-Commit-Position: refs/heads/master@{#454884} Committed: https://chromium.googlesource.com/chromium/src/+/99ee0570b40f1e61e27a35d8b41c52e892e0fd01

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -38 lines) Patch
M ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm View 3 chunks +20 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm View 1 3 chunks +4 lines, -33 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-06 12:22:14 UTC) #4
jif
lgtm
3 years, 9 months ago (2017-03-06 13:23:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734763003/1
3 years, 9 months ago (2017-03-06 13:23:35 UTC) #7
jif
Note: If you want to go the extra mile (in a different CL), you can ...
3 years, 9 months ago (2017-03-06 13:25:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/167043)
3 years, 9 months ago (2017-03-06 13:52:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734763003/20001
3 years, 9 months ago (2017-03-06 17:30:55 UTC) #13
gambard
On 2017/03/06 13:25:38, jif wrote: > Note: > If you want to go the extra ...
3 years, 9 months ago (2017-03-06 17:31:00 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 18:02:22 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/99ee0570b40f1e61e27a35d8b41c...

Powered by Google App Engine
This is Rietveld 408576698