Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: client/lib/components/parameters.dart

Issue 273473002: Display function signatures instead of just "Function". (Closed) Base URL: https://github.com/dart-lang/dartdoc-viewer.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/lib/components/method.html ('k') | client/lib/components/parameters.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/lib/components/parameters.dart
diff --git a/client/lib/components/parameters.dart b/client/lib/components/parameters.dart
index 1331474c435bcd17079828aa960b4216533223bc..e348bb860fb91ae775df9049ec557f523429767e 100644
--- a/client/lib/components/parameters.dart
+++ b/client/lib/components/parameters.dart
@@ -11,12 +11,16 @@ import 'package:polymer/polymer.dart';
import 'package:dartdoc_viewer/item.dart';
import 'package:dartdoc_viewer/member.dart';
+import 'closure.dart';
import 'type.dart';
@CustomTag("dartdoc-parameter")
class ParameterElement extends DartdocElement {
@published List<Parameter> parameters = const [];
+
+ factory ParameterElement() => new Element.tag('dartdoc-parameter');
+
ParameterElement.created() : super.created();
void parametersChanged() {
@@ -52,13 +56,21 @@ class ParameterElement extends DartdocElement {
outerSpan.append(new TypeElement()..type = element.type);
space = ' ';
}
- var parameterName = new AnchorElement()
- ..text = element.name
- ..href = element.prefixedAnchorHref
- ..id = element.anchorHrefLocation.anchor;
+
outerSpan.appendText(space);
- outerSpan.append(parameterName);
+ if (element.functionDeclaration != null) {
+ outerSpan.append(
+ new ClosureElement()..closure = element.functionDeclaration);
+ } else {
+ var parameterName = new AnchorElement()
+ ..text = element.name
+ ..href = element.prefixedAnchorHref
+ ..id = element.anchorHrefLocation.anchor;
+
+ outerSpan.append(parameterName);
+ }
outerSpan.appendText(element.decoration);
+
if (className == 'required' && optional.isNotEmpty ||
element != elements.last) {
outerSpan.appendText(', ');
@@ -71,4 +83,4 @@ class ParameterElement extends DartdocElement {
}
this.append(outerSpan);
}
-}
+}
« no previous file with comments | « client/lib/components/method.html ('k') | client/lib/components/parameters.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698