Issue 273473002: Display function signatures instead of just "Function".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 273473002: Display function signatures instead of just "Function". (Closed)

Created:
6 years, 7 months ago by Emily Fortuna

Modified:
6 years, 7 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dartdoc-viewer.git@master

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -11 lines)			Patch
M	client/lib/components/category.dart	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	client/lib/components/category.html	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
A	client/lib/components/closure.dart	View		1 chunk	+46 lines, -0 lines	0 comments	Download
A	client/lib/components/closure.html	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	client/lib/components/library.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	client/lib/components/method.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/lib/components/parameters.dart	View		3 chunks	+18 lines, -6 lines	0 comments	Download
M	client/lib/components/parameters.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/lib/components/typedef.html	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	client/lib/item.dart	View	1	3 chunks	+34 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Alan Knight

One issue. If I click on a reference to a parameter in the comment, normally ...

6 years, 7 months ago (2014-05-07 16:57:08 UTC) #2

Emily Fortuna

PTAL -- I fixed the URLs for the function parameters.

6 years, 7 months ago (2014-05-07 17:57:14 UTC) #3

Emily Fortuna

6 years, 7 months ago (2014-05-07 19:53:10 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r7e501cd (presubmit successful).