Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2734693002: [Payments] Convert interactive tests to browsertests (Closed)

Created:
3 years, 9 months ago by Mathieu
Modified:
3 years, 9 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, darin-cc_chromium.org, gogerald+paymentswatch_chromium.org, jam, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Convert interactive tests to browsertests * Enables the tests on Mac * Now in the browser_tests target * No longer uses interactive test utils (not linked in browser_tests) BUG=696029 TEST=browser_tests Review-Url: https://codereview.chromium.org/2734693002 Cr-Commit-Position: refs/heads/master@{#454877} Committed: https://chromium.googlesource.com/chromium/src/+/87a17804ec5928ea8f3def2e7ddc7d262f5007c4

Patch Set 1 #

Patch Set 2 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -1485 lines) Patch
A + chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
D chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc View 1 chunk +0 lines, -103 lines 0 comments Download
A + chrome/browser/ui/views/payments/payment_request_browsertest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/ui/views/payments/payment_request_browsertest_base.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/ui/views/payments/payment_request_browsertest_base.cc View 21 chunks +55 lines, -55 lines 0 comments Download
D chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc View 1 chunk +0 lines, -439 lines 0 comments Download
D chrome/browser/ui/views/payments/payment_request_interactive_uitest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h View 1 chunk +0 lines, -207 lines 0 comments Download
D chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.cc View 1 chunk +0 lines, -359 lines 0 comments Download
A + chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
D chrome/browser/ui/views/payments/payment_sheet_view_controller_interactive_uitest.cc View 1 chunk +0 lines, -154 lines 0 comments Download
M chrome/browser/ui/views/payments/view_stack.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 chunks +6 lines, -12 lines 0 comments Download
M components/payments/content/payment_request_web_contents_manager.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Mathieu
PTAL!
3 years, 9 months ago (2017-03-06 14:07:30 UTC) #9
anthonyvd
lgtm
3 years, 9 months ago (2017-03-06 14:47:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734693002/20001
3 years, 9 months ago (2017-03-06 14:47:29 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 16:53:45 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/87a17804ec5928ea8f3def2e7ddc...

Powered by Google App Engine
This is Rietveld 408576698