Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2734673002: Send error notifications only for files in analysis roots (and not excluded). (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Send error notifications only for files in analysis roots (and not excluded). R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/24d5466a72a34cfe1fca15bb6f546553dc3bf4ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-05 03:19:10 UTC) #1
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-05 16:09:27 UTC) #2
scheglov
3 years, 9 months ago (2017-03-05 23:01:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
24d5466a72a34cfe1fca15bb6f546553dc3bf4ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698